Skip to content
This repository has been archived by the owner on May 26, 2019. It is now read-only.

Adds file names to code blocks when present #35

Merged
merged 1 commit into from
Mar 8, 2015
Merged

Adds file names to code blocks when present #35

merged 1 commit into from
Mar 8, 2015

Conversation

danmcclain
Copy link
Contributor

Closes #30

This only updates 1 code fence as an example, visible at http://localhost:4567/templates/the-application-template/

@danmcclain
Copy link
Contributor Author

Wanted to share progress with it so far for feedback. Will add tests later today/tomorrow

/cc @rwjblue @trek

@trek
Copy link
Member

trek commented Mar 7, 2015

Seems good. You can leave the require 'pry' in. It doesn't affect anything and helps those debugging.

@danmcclain
Copy link
Contributor Author

Sounds good. There are existing tests failing on master. Do you mind if I add tests for the fencing and don't touch the existing a tests in this PR, then address them in a second PR?

@trek
Copy link
Member

trek commented Mar 7, 2015

sounds good.

@danmcclain
Copy link
Contributor Author

@trek: Tests added. Ready to be merged

trek added a commit that referenced this pull request Mar 8, 2015
Adds file names to code blocks when present
@trek trek merged commit 68e494c into emberjs:master Mar 8, 2015
@danmcclain danmcclain deleted the new-code-fences branch March 8, 2015 22:43
@joostdevries joostdevries mentioned this pull request Mar 14, 2015
19 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use fenced code metadata to annotate both file location and language
2 participants