Rewrote components to cli in the guide #18
Conversation
| // app/components/navigation-bar.js | ||
| import Ember from 'ember'; | ||
|
|
||
| var NavigationBarComponent = Ember.Component.extend({ |
There was a problem hiding this comment.
export default Ember.Component.extend(
|
I see. Shall I revise all the pages and resend? Can I just cancel this PR for now? |
|
@nicolechung updating this PR would be best, as it will remove the comments are the lines it reference change. |
|
Okay...how do I do that? Can I just make my changes and push them out on the same branch? |
|
@nicolechung yup, exactly. |
|
Okay, changed my editor to two space tabs instead of four and removed unnecessary var usage. Hope I caught everything. I also updated the JSbins to remove vars. |
|
@trek JSbins commented out... |
|
|
||
| The example above uses `<script>` tags to work inside of JSBin.--> | ||
|
|
||
| Ember-cli works by file structure, so there are no `<script>` tags: |
There was a problem hiding this comment.
Seems odd to call this out here, I think this sentence should be removed.
There was a problem hiding this comment.
Oh yeah...that was to explain the JSbins (which have been removed). Will do.
| ``` | ||
|
|
||
| If you're using build tools, create a Handlebars file at | ||
| `templates/components/blog-post.handlebars`. | ||
| `app/components/blog-post.hbs`. |
There was a problem hiding this comment.
app/templates/components/blog-post.hbs
|
|
||
| If you're using build tools, create a Handlebars file at | ||
| `templates/components/blog-post.handlebars`. | ||
| ```app/components/blog-post.hbs |
There was a problem hiding this comment.
app/templates/components/blog-post.hbs
|
Thanks for your hard work on this! I just finished going through the whole diff, and I think I've flagged all the nit-picks I can. Once these are fixed, I'll review once more and this should be good to merge. |
Rewrote components to cli in the guide
|
Thank you! |
With new JSbins.