This repository has been archived by the owner on May 26, 2019. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 873
Update contributions section for CLI #69
Merged
mixonic
merged 2 commits into
emberjs:master
from
stevekinney:update-contributing-for-cli
Mar 20, 2015
Merged
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -44,7 +44,7 @@ problems with early return. | |
```js | ||
if (Ember.FEATURES.isEnabled("feature")) { | ||
// implementation | ||
} | ||
} | ||
``` | ||
|
||
Tests will always run with all features on, so make sure that any tests | ||
|
@@ -64,7 +64,7 @@ described above. | |
|
||
#### Feature Naming Conventions | ||
|
||
```js | ||
```config/environment.js | ||
Ember.FEATURES["<packageName>-<feature>"] // if package specific | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think we need to change this? |
||
Ember.FEATURES["container-factory-injections"] | ||
Ember.FEATURES["htmlbars"] | ||
|
@@ -77,8 +77,16 @@ guarded by the conditionals in the original source. This means that | |
users of the canary build can enable whatever features they want by | ||
enabling them before creating their Ember.Application. | ||
|
||
```js | ||
Ember.FEATURES["htmlbars"] = true; | ||
```config/environment.js | ||
module.exports = function(environment) { | ||
var ENV = { | ||
EmberENV: { | ||
FEATURES: { | ||
Ember.FEATURES["htmlbars"] = true | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. https://github.com/ember-cli/ember-cli/pull/958/files#diff-9588ab8abb99afa6cac30dd0e2b86041R8 it should be FEATURES: {
'htmlbars': true`
} |
||
} | ||
}, | ||
} | ||
} | ||
``` | ||
|
||
### `features.json` | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what about this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That would be in the Ember source code—not in a CLI project, I believe.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
technically it is ;-) but seems good