Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Tracked Maps and Sets #577
I am unaware of how this works. Right now we can only do "manual tree shaking" in ember-cli; i.e. not load a package. While Embroider may change this someday, we must work with what we have now. Once Ember core is property separated into real separate packages, with today's ember-cli we will be able to only load or not load the entire package.
@Gaurav0 I just mean that I feel like we have too many imports as is -- not that there is anything we can do about it -- all the imports make sense.
IMHO, I disagree. The
The only additional thing I think should be added to the
Seems like I have misunderstood the role of proxies here. I still think support for IE 11 should be dropped, but that isn't relevant to this discussion.
I'm very much in favour of this RFC!
Good suggestion, I really like this idea!
However, I think designing something proxy-based would be much better and browser support is excellent. Let's come up with something modern, with longer shelf-life.
IE 11 is in rapid decline and only have a few percentage points of usage these days.
Many large software companies has already stopped supporting it, for example:
The days where IE11 was the only browser installed on a computer are long gone.
Ember should drop IE 11 support and focus time on using the modern JS toolset to provide a nice framework. Any Ember user that need to extend support a while longer, e.g. end of 2020, could simply linger on an Ember LTS a while longer. It doesn't need to hold back new framework development.
Regarding the performance drawback with proxies, I don't think it would be a big problem under most real-world scenarios.
@sandstrom these classes do not require a proxy to wrap transparently, since all access is done through methods, unlike arrays. Ultimately, the exact implementation should likely be whatever is most performant, and whether or not that is a subclass or a proxy should be an implementation detail.