Skip to content
This repository has been archived by the owner on Mar 22, 2019. It is now read-only.

Added deprecation guide about Ember.computed.any #2313

Merged
merged 1 commit into from Aug 18, 2015

Conversation

phkavitha
Copy link
Contributor

My first commit towards fixing #2256.

@wycats
Copy link
Member

wycats commented Aug 15, 2015

@phkavitha Thanks for submitting this. I look forward to merging it.

A couple of things:

  1. We use American spelling for favor (o rather than ou).
  2. We generally add a colon to a sentence that is immediately followed by an example (For example: rather than For example,).
  3. The reason we changed from any to or is to reflect the fact that the computed value is the first successful value (like ||) rather than a boolean (like Array.prototype.any). It might be useful to include that information.

Thanks so much again for the contribution!

@wycats
Copy link
Member

wycats commented Aug 15, 2015

Also, can you rebase?

@phkavitha phkavitha force-pushed the master branch 2 times, most recently from 0df3156 to 7f3dd32 Compare August 18, 2015 02:56
The deprecation message for Ember.computed.any is tweaked
@phkavitha
Copy link
Contributor Author

@wycats , I have made the necessary changes. Let me know if any changes are required. Thanks for your help.

rwjblue added a commit that referenced this pull request Aug 18, 2015
Added deprecation guide about Ember.computed.any
@rwjblue rwjblue merged commit acbc337 into emberjs:master Aug 18, 2015
@rwjblue
Copy link
Member

rwjblue commented Aug 18, 2015

Thank you!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants