-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
WIP: Setup a Features dashboard to show upcoming feature flags #2393
Conversation
I think we generally want it, and it was dropped due to lack of time. I'm also a tad concerned with upkeep after the initial push is done. It would be unfortunate to have a nice page with these details that never gets updated. Definitely looking for folks to help with this sort of thing.... |
Agreed. Seems like this is only useful if it doesn't add more work to your workflow. I'd been thinking of doing Ajax calls back to Github to retrieve the features.json file from the various branches, but would need meta info (primarily a description and probably the original pull request / rfc). Is there some way we can shoehorn that into the features.json file without breaking the rest of our infrastructure? I'd wondered about doing this In features.json:
What I would hope is that the feature system would be able to continue doing it's true / false comparisons while allowing us to read more meta data as desired. Do you think that'd be doable or will that break a ton of things? |
FWIW features already have descriptions at https://github.com/emberjs/ember.js/blob/master/FEATURES.md |
Good point on those features being there. I was hoping to not have to parse Markdown in order to display things on that dashboard though ;-) Think that'd be best or can we wangle this some other way? |
@acorncom we've talked about changing the format of |
@acorncom incidentally, we had already designed an improved dashboard that maybe you want to take a crack at (thanks @thoughtbot). |
It would probably make sense for the timeline to be in reverse order (most recent on the top). |
Also, putting the features in |
Question regarding the dashboard design. Per @locks on this pull request (at the bottom), the thoughtbot redesign for the guides looks different than the design for the builds page. Are we keeping a common header across the various pages or are these pages going to look different? |
Re: where to retrieve data. I can pull from But I'd prefer using a |
Two other questions:
|
Ya, we will have to have a way to see past versions (but it might be included in another page).
Yes, the builds page should move to an ember-cli app that is built then copied into the current website upon deploy. I do not think it should incorporate other sections, but don't feel super strongly about this. |
I am closing this issue because I'm mostly done porting the builds page into an Ember CLI application, and this should be moved into our internal tracking until we actually start work on it. |
I noticed a Dashboard page that @wycats built earlier this year (https://github.com/emberjs/website/blob/master/source/dashboard.html.erb) but it looks like it never got fully implemented.
This pull request picks up where he left off and moves it in under the Builds area of the website:
![screen shot 2015-10-20 at 10 10 30 pm](https://cloud.githubusercontent.com/assets/802505/10627487/6a2a980c-7777-11e5-91e2-c42a7840e173.png)
My main question before I work on this much further is: is this something we actually want to do? Did it get left undone due to lack of time or did the core team decide it shouldn't happen?
If we want it to happen, I'll enjoy messing around here a bit :-)