Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

whatwg-fetch, ember-fetch devDependency, and addon-docs upgrade #26

Merged
merged 2 commits into from
Jan 25, 2019

Conversation

ryanto
Copy link
Member

@ryanto ryanto commented Jan 25, 2019

ember-cli-fastboot-testing no longer has a dependency on ember-fetch, which solves the issue reported in #21. ember-fetch has now moved to a devDependency so we can run addon-docs in fastboot.

The reason this was doable is because we're only using fetch to pull fastboot instance data from ember-cli, outside of the lifecycle of the Ember application. Since our use case for fetch is so simple, we can get away with using whatwg-fetch directly.

Also, this PR upgrades addon docs 🎉

Related:

#21

ember-fastboot/ember-cli-fastboot#597

ember-cli/ember-fetch#98

ember-cli/ember-fetch#126

@ryanto ryanto merged commit 6c4897e into master Jan 25, 2019
@ryanto ryanto deleted the fetch-version branch January 25, 2019 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant