Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[POC] Span links #819

Closed
wants to merge 1 commit into from
Closed

[POC] Span links #819

wants to merge 1 commit into from

Conversation

priettt
Copy link
Contributor

@priettt priettt commented May 7, 2024

Goal

This quarter, one of the highlighter team's goals is to show NetworkRequests as spans in the dashboard, under the traces where they happen. Link to ticket

A way of doing that is adding every ongoing span as a Span Link in the network request span.

This PR makes it possible to add span links to every span, and in particular, it adds every ongoing span that doesn't start with "emb-" to the network request spans as a span link.

It's a POC; I'm mainly uploading it to have a working sample of how we could add links, but some things might be wrong.

Considerations

  • We need to update the OTel dependency as links were added in the latest version of the SDK.
  • We should probably add TraceState and TraceFlags to EmbraceSpanContext to be aligned with OTel.
  • We might want to link only the deepest spans of a trace, without the parent spans.
  • I exposed getActiveSpans in the SpanService so that we could get the active spans in the NetworkLoggingService. We might want to expose the active spans in a different way.
  • We should think of a better way to ignore embrace spans than checking if they start with "emb-".
  • We should add tests.

Copy link
Contributor

github-actions bot commented Jun 7, 2024

This PR is stale because it has been open 20 days with no activity. Remove stale label or comment or this PR will be closed in 10 days.

@github-actions github-actions bot added the stale label Jun 7, 2024
Copy link
Contributor

This PR was closed due to inactivity.

@github-actions github-actions bot closed this Jun 17, 2024
@priettt priettt deleted the span-links branch September 17, 2024 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant