Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
This quarter, one of the highlighter team's goals is to show NetworkRequests as spans in the dashboard, under the traces where they happen. Link to ticket
A way of doing that is adding every ongoing span as a Span Link in the network request span.
This PR makes it possible to add span links to every span, and in particular, it adds every ongoing span that doesn't start with
"emb-"
to the network request spans as a span link.It's a POC; I'm mainly uploading it to have a working sample of how we could add links, but some things might be wrong.
Considerations