Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to gradle 8.7 #880

Merged
merged 1 commit into from
May 24, 2024
Merged

Update to gradle 8.7 #880

merged 1 commit into from
May 24, 2024

Conversation

fractalwrench
Copy link
Contributor

Goal

Updates gradle to the latest version.

@fractalwrench fractalwrench requested a review from a team as a code owner May 23, 2024 10:21
Copy link

codecov bot commented May 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.89%. Comparing base (d290a2b) to head (fdf8ab6).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #880      +/-   ##
==========================================
- Coverage   80.92%   80.89%   -0.03%     
==========================================
  Files         435      435              
  Lines       11616    11616              
  Branches     1764     1764              
==========================================
- Hits         9400     9397       -3     
  Misses       1438     1438              
- Partials      778      781       +3     

see 2 files with indirect coverage changes

distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-8.7-bin.zip
networkTimeout=10000
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this for? This timeout value seems too small?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was added automatically by Gradle when I ran the wrapper task. I'll remove it

Copy link
Collaborator

@bidetofevil bidetofevil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. One question about the network timeout value - if it's actually applicable to fetch tasks that we execute, we may want to bump that up to 30 or 60s so we don't have slow networks nuking builds?

@fractalwrench fractalwrench merged commit cd1b85e into master May 24, 2024
4 checks passed
@fractalwrench fractalwrench deleted the update-gradle branch May 24, 2024 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants