Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create and provide an Embrace implementation for OpenTelemetry #971

Merged
merged 1 commit into from
Jun 18, 2024

Conversation

bidetofevil
Copy link
Collaborator

@bidetofevil bidetofevil commented Jun 17, 2024

Goal

Expose an implementation of the OpenTelemetry interface (i.e. object from which you can record all OTel signals) that includes our implementation of TracerProvider. This is needed for instrumentation libraries that don't take just a Tracer, but then entire OpenTelemetry interface.

Testing

Add tests to all levels

Copy link
Collaborator Author

bidetofevil commented Jun 17, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @bidetofevil and the rest of your teammates on Graphite Graphite

Copy link

codecov bot commented Jun 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.92%. Comparing base (6ffaaa1) to head (88447e6).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #971      +/-   ##
==========================================
- Coverage   80.97%   80.92%   -0.05%     
==========================================
  Files         444      445       +1     
  Lines       11814    11824      +10     
  Branches     1805     1806       +1     
==========================================
+ Hits         9566     9569       +3     
- Misses       1456     1459       +3     
- Partials      792      796       +4     
Files Coverage Δ
...in/java/io/embrace/android/embracesdk/Embrace.java 81.54% <100.00%> (+0.11%) ⬆️
...ndroid/embracesdk/injection/OpenTelemetryModule.kt 93.33% <100.00%> (+0.35%) ⬆️
...embrace/android/embracesdk/internal/api/OTelApi.kt 50.00% <ø> (ø)
...mbracesdk/internal/api/delegate/OTelApiDelegate.kt 88.88% <100.00%> (+2.22%) ⬆️
...droid/embracesdk/opentelemetry/EmbOpenTelemetry.kt 100.00% <100.00%> (ø)

... and 3 files with indirect coverage changes

@bidetofevil bidetofevil marked this pull request as ready for review June 17, 2024 21:38
Copy link
Contributor

@fractalwrench fractalwrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bidetofevil bidetofevil merged commit bbdea78 into master Jun 18, 2024
4 checks passed
@bidetofevil bidetofevil deleted the hho/emb-opentelemetry branch June 18, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants