Run the clean plugin of addon-dev as late as possible

[simonihmig]

This attempts to fix the problem described in embroider-build/addon-blueprint#32.

While it is not the perfect solution like a truly atomic build update, it seems "good enough". Previously the cleanup would happen at the earliest point in time, at buildStart, making the time window large enough for Ember CLI to see the transient build output in an inconsistent state. Now it happens at the latest possible time, at generateBundle right before files are written, making the time window small enough to not cause any problems in practice. (successfully tested locally)

[ef4]

Thanks.

I wonder if, now that we have https://github.com/embroider-build/addon-blueprint/blob/d64ff367581eb95e5c92ea4d9799ddcfb44ef437/files/__addonLocation__/rollup.config.js we could just link people to there instead of maintaining this example file here too, and worrying about keeping them in sync.

[simonihmig]

Not sure I understand what you mean...

The change here is in the Addon class, that exposes the various rollup plugins in a somewhat simplified form (less config work). It's not just an example file, we are importing and using it in the actual addon (and as such also in the blueprint). Means once this is published and addons update the dependency, they will get the new behavior, without any "syncing".

Or do you think in hindsight, that the Addon class itself should be dropped, and addons should do the whole setup on their own?

[ef4]

Oh, I'm sorry I misunderstood. I was imagining this was a change to https://github.com/embroider-build/embroider/blob/7bbd49c55a4b0f3bf4a1605f5307c412c089cfa0/packages/addon-dev/sample-rollup.config.js (which we could indeed remove from this repo in favor of the blueprint repo).