Addon-shim was missing dependencies

[NullVoxPopuli]

This came up when I moved broccoli-funnel to nohoist in a yarn project -- got an error about broccoli-funnel not being found

[ef4]

Does broccoli-node-api break if you don't change it? Because it's types-only and I don't think our own types refer to them, so it seems like it could stay a devDependency.

As for the other one, we should also figure out why we don't have a lint rule to catch this.

[NullVoxPopuli]

yeah that one is fine as a devDep, I just got carried away it my hastily made PR.

I'll look for a lint for the imports and open a separate PR for that (this is something $work wants, too, so hopefully whatever I find works for both places!)

[ef4]

I'll look for a lint for the imports and open a separate PR for that (this is something $work wants, too, so hopefully whatever I find works for both places!)

It's normally handled by node/no-extraneous-import and node/no-extraneous-require.

People seem to be moving from eslint-plugin-node to eslint-plugin-n, a fork that is more maintained.

[NullVoxPopuli]

yeah, eslint-plugin-node barely supports anything these days (except old cjs)