Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clarify which package rules apply inside vs outside a component #1362

Merged
merged 1 commit into from
Feb 15, 2023
Merged

clarify which package rules apply inside vs outside a component #1362

merged 1 commit into from
Feb 15, 2023

Commits on Feb 15, 2023

  1. clarify which package rules apply inside vs outside a component 

    Previously we were keying all component rules off the actual on-disk file for that component, even when those rules were being consume at *invocation sites* of the component rather than inside the component itself. This meant that we could not apply those rules if we move component resolution out of the AST transform stage.

But it's actually OK to key the exterior rules off the component's globally-addressable (or at least engine-scoped) name, since the point of the rules is to control classic global resolution.
    @ef4
    ef4 committed Feb 15, 2023
    Configuration menu
    Copy the full SHA
    e806cc7 View commit details
    Browse the repository at this point in the history