allow null
, undefined
, if
and unless
for strict component arguments
#922
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am not 100% sure, but I think that this should be correct and fixes #921.
With this PR, the following would be allowed with
strictComponents=true
:Basically, it specifically allows
null
,undefined
,ensure-safe-component
,if
andunless
. When usingif
orunless
, it will check if each path either returns null/undefined or a valid component. So the following will still fail:I added a bunch of tests hopefully covering this well.