Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable dependabot for libraries #14

Merged
merged 1 commit into from
May 9, 2024
Merged

Enable dependabot for libraries #14

merged 1 commit into from
May 9, 2024

Conversation

dmikurube
Copy link
Member

No description provided.

@dmikurube dmikurube requested a review from a team as a code owner May 8, 2024 08:21
Copy link
Member

@hiroyuki-sato hiroyuki-sato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍

Could you tell me the detail about dependabat check libraries?

gradle/libs.versions.toml contains the following libraries.

    compileOnly libs.embulk.spi
    compileOnly libs.slf4j

    implementation libs.embulk.util.config
    implementation libs.validation
    implementation platform(libs.jackson.bom)
    implementation libs.bundles.jackson

    implementation libs.embulk.util.file

    implementation libs.commons.compress
    implementation libs.commons.codec
    implementation libs.commons.io
    implementation libs.commons.lang3

.github/dependabot.yml contains.

      - dependency-name: "org.embulk.embulk-plugins"
      - dependency-name: "org.embulk:embulk-spi"
      - dependency-name: "org.embulk:embulk-util-config"
      - dependency-name: "org.embulk:embulk-util-file"
      - dependency-name: "org.apache.commons:commons-lang3"
      - dependency-name: "commons-codec:commons-codec"
      - dependency-name: "commons-io:commons-io"
      - dependency-name: "org.apache.commons:commons-compress"

There are no entries slf4j and jackson and validation. IIUC, Those libraries update without dependabat. So, It does not contain in .github/dependabot.yml
Is my understanding correct?

@dmikurube
Copy link
Member Author

dmikurube commented May 8, 2024

Good question. For built-in plugins, I now enable dependabot only for :

  • implementation dependencies (not for compileOnly nor testImplementation)
    • slf4j-api is rejected.
    • embulk-spi is our own, then to be upgraded, though.
  • Non-Jackson
    • Jackson is often sensitive about compatibilities between versions.
    • I now think it still needs manual confirmation.
    • We may try automatic upgrades only for "the patch version (the third digit)" later.
  • Non-Validation API
    • Validation API would just follow embulk-util-config.

@hiroyuki-sato
Copy link
Member

Thanks! LGTM👍

I created the issue embulk/embulk#1658 for future development.

@dmikurube
Copy link
Member Author

dmikurube commented May 9, 2024

Thanks!

Documenting is always good, but note that the policy may often change depending on the siatuations, including the tooling quality, the update policy of each library project, our clean up, and else...

@dmikurube dmikurube merged commit da53cd4 into main May 9, 2024
4 checks passed
@dmikurube dmikurube deleted the dependabot-librarires branch May 9, 2024 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants