Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pycryptodome instead of pycryptodomex #72

Merged

Conversation

ngie-eign
Copy link
Contributor

While pycryptodomex and pycryptodome have similar lineages,
pycryptodomex doesn't seem to be as actively developed as
pycryptodome is.

Keep the cryptodomex namespace imports in place to allow existing
users to use cryptodomex, if it's already installed.

Signed-off-by: Enji Cooper yaneurabeya@gmail.com

@masenf
Copy link
Collaborator

masenf commented Feb 12, 2020

My only hesitation with this patch is that if users have PyCrypto installed, then pike will break. Maybe that's not a big concern though

pike/digest.py Outdated Show resolved Hide resolved
ngie-eign and others added 2 commits November 6, 2022 13:32
While `pycryptodomex` and `pycryptodome` have similar lineages,
`pycryptodomex` doesn't seem to be as actively developed as
`pycryptodome` is.

Keep the `cryptodomex` namespace imports in place to allow existing
users to use `cryptodomex`, if it's already installed.

Signed-off-by: Enji Cooper <yaneurabeya@gmail.com>
@isi-mfurer isi-mfurer force-pushed the use-cryptodome-instead-of-cryptodomex branch from 54fb899 to 78c7093 Compare November 6, 2022 21:40
@isi-mfurer isi-mfurer merged commit 6f880d3 into emc-isilon:master Nov 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants