Fix several issues #188
Merged
Fix several issues #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 18, 2017
t3hk0d3
force-pushed
the
fix_issues
branch
2 times, most recently
from
04b0162
to
686f2eb
Compare
|
Can you please take a look @emcrisostomo ? :) |
|
Hi @t3hk0d3, Thank you very much for the PR. I will have a look at them as soon as possible. I will definitely have to test compiling a C program against |
|
@emcrisostomo If it is difficult to merge everything in a single PR - i can split it into 3 PRs. |
|
Nope thanks @t3hk0d3, I just have a problem with time |
|
Merged. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've decided to group several fixes into single PR, instead of having them separately.
cevent.hnot being C99 compliant (C++ stuff leaking into C headers)Debatable change, might potentially break existing code. However documentation says:
fsw_start_monitorif there is errors insidecreate_monitor(for example callback is not set)