Fix `SubspaceDiscrete.from_dataframe` edge case #360

AdrianSosic · 2024-09-03T08:31:55Z

Fixes #358 by:

Catching the edge case when a degenerate dataframe with no columns is provided
Updating the meta data only when discrete subspace is present (not required for the bugfix but still to be changed)

baybe/campaign.py

Scienfitz · 2024-09-05T08:09:18Z

Changelog

AdrianSosic added the bug Something isn't working label Sep 3, 2024

AdrianSosic self-assigned this Sep 3, 2024

AdrianSosic requested review from Scienfitz and AVHopp as code owners September 3, 2024 08:31

AdrianSosic commented Sep 3, 2024

View reviewed changes

baybe/campaign.py Outdated Show resolved Hide resolved

Scienfitz approved these changes Sep 3, 2024

View reviewed changes

AVHopp approved these changes Sep 3, 2024

View reviewed changes

baybe/campaign.py Outdated Show resolved Hide resolved

AdrianSosic force-pushed the bugfix/from_dataframe branch from 4f3224a to 4d4fa0d Compare September 4, 2024 09:07

AdrianSosic added 4 commits September 5, 2024 11:03

Catch degenerate dataframe edge case

8a05121

Update metadata only in purely discrete spaces

9ff6cfa

Update metadata also in hybrid spaces

c02191e

Update CHANGELOG.md

809507c

AdrianSosic force-pushed the bugfix/from_dataframe branch from 4d4fa0d to 809507c Compare September 5, 2024 09:10

AdrianSosic merged commit 7e874db into main Sep 5, 2024
9 of 11 checks passed

AdrianSosic deleted the bugfix/from_dataframe branch September 5, 2024 09:48

Provide feedback