Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Minor Fixes 23-11 #78

Merged
merged 7 commits into from
Dec 20, 2023
Merged

Fix: Minor Fixes 23-11 #78

merged 7 commits into from
Dec 20, 2023

Conversation

bluesd
Copy link
Contributor

@bluesd bluesd commented Dec 1, 2023 •
edited
Loading

sensum-pwa

  • Bump .nvmrc from fermium to hydrogen
  • Change project type to ESM modules
    • Change type in package.json
    • Leave postcss and tailwind as CJS
  • On screen width reduce
    • Reduce Navbar title size
    • Change Graveyard text to G
    • Change Sanctuary text to S
  • On NewSensation screen, truncate address and mana if width is not enough
  • On Sensations screen, make sensation's text scrollable if it overflows vertically

bluesd and others added 7 commits December 1, 2023 11:33
@bluesd
fix: nvm version bumped to lts/hydrogen
ddf3d6b
@bluesd
fix: Change types to modules
9368fdc 
Keep postcss and tailwind as cjs code (with proper extension)
@bluesd
feat: Media breakpoints for NavBarButtons
286e8ee 
* When page size reduces:
  * Reduce title size
  * Change Graveyard text for a G
  * Change Sanctuary text for an S

TODO:

Convert into an hamburguer menu
@bluesd
fix: Truncate address and mana on overflow
faece61
@bluesd
fix: Add scrollbar for vertically long sensations
4a22809
@mk-emeks
Merge branch 'master' into fix/MinorFixes23-11
6b06048
@mk-emeks
minor space issue
cdc8d40
@mk-emeks mk-emeks marked this pull request as ready for review December 20, 2023 01:05
@mk-emeks mk-emeks merged commit ffe0bb9 into master Dec 20, 2023
@mk-emeks mk-emeks deleted the fix/MinorFixes23-11 branch December 20, 2023 01:05
This was referenced Jan 2, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bluesd @mk-emeks