Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MPI Divergence issues #187

Merged
merged 2 commits into from
Apr 4, 2023
Merged

Fix MPI Divergence issues #187

merged 2 commits into from
Apr 4, 2023

Conversation

siboehm
Copy link
Member

@siboehm siboehm commented Apr 3, 2023

  • Compute TrgActAvg after MPI sync
  • Add test for CollectDwt and SetDwt

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.97 🎉

Comparison is base (4b3d273) 39.25% compared to head (41c4e8a) 40.22%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #187      +/-   ##
==========================================
+ Coverage   39.25%   40.22%   +0.97%     
==========================================
  Files          53       53              
  Lines       10285    10285              
==========================================
+ Hits         4037     4137     +100     
+ Misses       6012     5915      -97     
+ Partials      236      233       -3     
Impacted Files Coverage Δ
axon/layer_compute.go 42.66% <ø> (+0.31%) ⬆️
axon/network.go 43.54% <100.00%> (+18.75%) ⬆️

... and 6 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@rcoreilly rcoreilly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@rcoreilly rcoreilly merged commit eaa5b0c into master Apr 4, 2023
@rcoreilly
Copy link
Member

ps. I'll make a new release tomorrow with my pcore / STN fixes too.

@siboehm siboehm deleted the siboehm/MPIDontDiverge branch April 4, 2023 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants