Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix additional address adding #1279

Merged
merged 16 commits into from
May 31, 2023
Merged

Fix additional address adding #1279

merged 16 commits into from
May 31, 2023

Conversation

BOOMER74
Copy link
Contributor

Also rewrite logic for useEffect when using async calls

@codecov
Copy link

codecov bot commented May 26, 2023

Codecov Report

Merging #1279 (206bb8e) into master (e593e93) will decrease coverage by 0.05%.
The diff coverage is 4.28%.

❗ Current head 206bb8e differs from pull request most recent head 54a892a. Consider uploading reports for the commit 54a892a to get more accurate results

@@            Coverage Diff             @@
##           master    #1279      +/-   ##
==========================================
- Coverage   35.19%   35.14%   -0.05%     
==========================================
  Files         428      428              
  Lines        8817     8828      +11     
  Branches     1152     1154       +2     
==========================================
  Hits         3103     3103              
- Misses       4652     4661       +9     
- Partials     1062     1064       +2     
Impacted Files Coverage Δ
packages/desktop/src/main/index.ts 0.00% <0.00%> (ø)
packages/desktop/src/main/utils/check-update.ts 0.00% <0.00%> (ø)
packages/desktop/src/main/utils/update-options.ts 0.00% <0.00%> (ø)
packages/desktop/src/main/utils/update-tokens.ts 0.00% <0.00%> (ø)
packages/desktop/src/renderer/store/store.ts 0.00% <0.00%> (ø)
...ages/react-app/src/app/AboutDialog/About/About.tsx 75.00% <0.00%> (ø)
...ages/react-app/src/app/AboutDialog/AboutDialog.tsx 0.00% <0.00%> (ø)
...ages/react-app/src/create-account/AddHDAddress.tsx 0.00% <0.00%> (ø)
...react-app/src/create-wallet/CreateWalletScreen.tsx 0.00% <0.00%> (ø)
packages/react-app/src/receive/ReceiveScreen.tsx 0.00% <0.00%> (ø)
... and 11 more

# Conflicts:
#	packages/store/src/accounts/sagas.ts
@splix splix merged commit 4741c6a into master May 31, 2023
@splix splix deleted the fix-additional-address branch May 31, 2023 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants