Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v2: initial implementation #490

Merged
merged 131 commits into from
Mar 17, 2023
Merged

v2: initial implementation #490

merged 131 commits into from
Mar 17, 2023

Conversation

emersion
Copy link
Owner

@emersion emersion commented Mar 11, 2023 •
edited
Loading

  • Hangs when a parse error happens in a FETCH (FetchCommand channel not closed)
  • Recover from panics in decoder goroutine
  • Figure out a better design for FetchItemDataSection
  • Figure out a better design for unilateral responses getting mixed up in regular responses
  • Add a way to test a connection's liveness (v1's LoggedOut channel)
  • Timeouts
  • Retrofit IMAP4rev1 support
  • Expose current state, capabilities, and selected mailbox data
  • Validate flags/mailbox/etc before encoding
  • Consider adding separate types for FetchItemData{Body,Binary}Section.Section
  • Parse and expose COPYUID in response to MOVE command
  • Add support for LITERAL-
  • Add IMAP4rev1 fallbacks for IDLE and MOVE
  • Add support for NAMESPACE
  • Add support for ESEARCH and SEARCH-RES

@emersion
imapwire: add IMAP encoder and decoder
a3a81b8
@emersion
imapclient: add IMAP client
07625e6
@emersion
imapwire: add support for encoding literals
b2771f0
@emersion
imapclient: add support for continuation requests
d291144
@emersion
imapclient: add APPEND
b62e0b5
@emersion
imapwire: add Decoder.Skip
1509bfd
@emersion
imapwire: include last unread byte in error messages
ba7a283
@emersion
imapclient: add SELECT
ae83a51
@emersion
imapwire: add Encoder.{Special,Number,Number64}
9b381de
@emersion
imapwire: add Decoder.Number64
ae97d40
@emersion
imapwire: add support for decoding literals
8c3dc81
@emersion
imapclient: add FETCH
de6e9a9
@emersion
imapclient: add STARTTLS
415156c
@emersion
imapclient: add IDLE
3c9c2bf
@emersion
imapclient: make beginCommand take the command as input
5d6546d 
We need to register the command before endCommand: literals are
sent before the command's final CRLF. When the server refuses a
literal, it fails the whole command.
@emersion
imapclient: add commandEncoder
f159ecb 
This makes it way clearer who's responsible for ending the command.
@emersion
imapclient: track continuation requests per-command
6149785
@emersion
imapclient: use per-command encoder
1a66189
@emersion
imapwire: make literals cancellable
738c850
@emersion
imapwire: add some docs
a92ef93
@emersion
imapclient: move Client.read up
8b30729
@emersion
imapclient: return data from SELECT command
4e47a8d
@emersion
imapclient: add Options
e2a3ad1
@emersion
imapclient: add basic support for unilateral data
64c0f64
@emersion
imapclient: fix races in StartTLS and Idle
f2a424e
@emersion
imapwire: don't panic on number64 overflow
0db9b19
@emersion
imapwire: add number decoding methods
d61101d
@emersion
imapclient: add STATUS
9f628ca
@emersion
imapwire: add Encoder.List
f8c6f11
@emersion
imapwire: add Decoder.ExpectList
3534a62
@emersion emersion added this to the v2 milestone Mar 17, 2023
@emersion
Copy link
Owner Author

Alright, I think this is a good starting point. Let's merge this and continue the work on the v2 branch.

@emersion emersion marked this pull request as ready for review March 17, 2023 12:24
@emersion emersion merged commit 79453e9 into v2 Mar 17, 2023
@emersion emersion deleted the v2-wip branch March 17, 2023 12:24
@emersion emersion mentioned this pull request Mar 17, 2023
Open
26 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2
Development

Successfully merging this pull request may close these issues.
1 participant
@emersion