Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Permit backend Auth method to return own error message #38

Closed
tuck1s opened this issue May 10, 2019 · 0 comments
Closed

Permit backend Auth method to return own error message #38

tuck1s opened this issue May 10, 2019 · 0 comments

Comments

@tuck1s
Copy link
Contributor

tuck1s commented May 10, 2019

Unlike the From, Rcpt, and Data backend hooks, the Auth hook's error message gets ignored, and always replaced with a 454.

go-smtp/conn.go

Line 363 in 930d6df

c.WriteResponse(454, EnhancedCode{4, 7, 0}, err.Error())

It would be nice to have the same error reporting as the other hooks.
tuck1s pushed a commit to tuck1s/go-smtp that referenced this issue May 10, 2019
Address emersion#38
74483b4
@tuck1s tuck1s mentioned this issue May 12, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tuck1s