Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved error handling #116

Merged
merged 6 commits into from
Sep 13, 2020
Merged

Improved error handling #116

merged 6 commits into from
Sep 13, 2020

Conversation

nsmith5
Copy link
Contributor

@nsmith5 nsmith5 commented Aug 11, 2020

This pull requests makes error handling a little more consistent and fixes issue #71. Pull request #72 has been open to address this issue for a while but without much sign of life from the author. This change

  • Factors the error handling into a function as suggested
  • Parametrizes the error threshold and defaults it to 3 (could be configurable in the future? At least it lives in one place now)

conn.go Outdated Show resolved Hide resolved
conn.go Outdated Show resolved Hide resolved
conn.go Outdated Show resolved Hide resolved
conn.go Outdated Show resolved Hide resolved
@nsmith5
Copy link
Contributor Author

nsmith5 commented Sep 13, 2020

@foxcpp Should be all good to go now 🎉

@foxcpp foxcpp merged commit f804d2f into emersion:master Sep 13, 2020
@foxcpp
Copy link
Collaborator

foxcpp commented Sep 13, 2020

Thanks!

This was referenced Sep 13, 2020
@nsmith5 nsmith5 deleted the bugfix/errorcount branch September 13, 2020 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants