-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide a configuration example file #316
Comments
If you're looking for an example yourself, here you go. An example config would be nice though, I agree. |
Thanks! I'll take a look at your dotfiles. |
Here's a more minimal example:
|
@fauust I presume you found That's where all the config keys are documented. The man page documentation format is ancient and not intuitive, but as seen in
|
Of course and I really like that all these projects use extensively man for documentation! What is missing for me, is a very basic example (maybe in the man). For instance, it was not clear for me, even reading the I would also add to your minimal example something like:
Just to show how sections should be used. |
Examples are important as much as a good documentation, so I took the liberty to do some copy&paste on the wiki from this issue and provide a configuration example to get started. It's not so pretty so feel free to improve it. |
I think providing a blank file with all options and some comments would be a good starting point, like
|
Why not but this information is already in the man pages so this could be redundant (and thus not easy to maintain)... |
my 2 cents on this feature request (as a mako user, not a contributor). Given how mako currently loads a default configuration (by hardcoding values in the code), I feel that duplicating a default config generator in another place would be slightly problematic if one day defaults change (as @fauust points out) So, in my opinion, either:
|
I didn't saw this update on the wiki, so this is perfectly sufficient IMO, I will be happy to close this issue if you agree with the wiki solution. |
I must say, i really dig the second option, but if that's too much trouble .. I like dumping a config file with all there is (up to this particular point) and then customize it, but that's just me ;) |
What I really don't want to see is a very big default config file with a ton of comments and all supported options specified. This just makes it very hard to figure out which parts you've customized. The documentation is the man page. The defaults are hard-coded in mako itself, and I agree this may not be the best option. While this makes it so mako doesn't hard-depend on a default system file, this makes it more difficult for users to start from scratch. In retrospect, maybe going the Sway way and falling back to However that would be a breaking change for our users. I'm not a fan of loading both the system-wide config file and the user-specific config file. |
Not having any internal defaults would also force the user config file to be exhaustive, because generating the style for a notification relies on having every value set to something after applying all the criteria. So we'd either have to fall back to the global config as you mentioned, or still have internal defaults anyway. Having a way of dumping out the defaults as a basic config file seems pretty reasonable to me, I would be +1 on a PR for that. The maintenance cost isn't zero but should be fairly low since the config format is pretty simple and we don't add new style options very often. |
All that said, the man page really should be sufficient documentation to get started. If it isn't, we should improve it. I have a feeling the criteria section could use a revamp, but if there's anything that people have found unclear about the basic options as well, please help us improve! Improving the text to clarify that there is no |
So, when I opened this issue I was migrating from i3/rofi/dunst, What do you think about this approach? Happy to PR this if it's ok for you. To lower the maintenance cost, I guess that it should not be too difficult to generate the wiki page from the manual section with the minimal config example (I have never done that on GitHub though). |
Just regarding this, the wiki is a git repository, so it should be possible to pretty easily have it convert defaults -> GitHub markdown and push it to the wiki repository as part of the CI. |
This sounds good to me:
|
How is app-name used? I have a bash script that uses notify-send that I want stylized differently. I don't think I need to define a mode for that and set it to that mode before calling notify-send and then setting it back to my default mode after every time, right? Also, is there a text log for history or is history only available through Apologies for derailing the discussion, not sure where else to ask this. |
From
You should ask on IRC in #emersion on irc.libera.chat as the README mentions. |
Ref #434 |
Hi! This is not an issue.
I can't find any configuration example in the documentation.
I think that for easier adoption, it would be very good to provide such a configuration example (or pointer to mako users dotfiles maybe?).
The text was updated successfully, but these errors were encountered: