Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a D-Bus service file for mako #156

Merged
merged 1 commit into from
May 24, 2019
Merged

Conversation

pmeiyu
Copy link

@pmeiyu pmeiyu commented May 23, 2019

This patch adds a D-Bus service file for mako.

I have never written any meson.build file before. Suggestions are welcome.

This patch also solves an annoying issue for Guix System. Guix has no systemd init system and $DBUS_SESSION_BUS_ADDRESS is not set in user sessions.
we had to start mako with dbus-launch --autolaunch=$(dbus-uuidgen --get) mako. After applying this patch, mako can be automatically started by the D-Bus daemon. That complex command is not needed anymore. I will update the package in Guix when this patch is merged.

Copy link
Owner

@emersion emersion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch, this looks fine to me

meson.build Outdated Show resolved Hide resolved
@emersion emersion merged commit ca8e763 into emersion:master May 24, 2019
@emersion
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants