Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add visual mark on App Menu opener when app update is available #35

Closed
emibcn opened this issue Oct 22, 2020 · 0 comments
Closed

Add visual mark on App Menu opener when app update is available #35

emibcn opened this issue Oct 22, 2020 · 0 comments
Labels
design Similar to UI/UX enhancement New feature or request good first issue Good for newcomers Hacktoberfest Simple issues suitable Hacktoberfest PRs javascript Javascript knowledge needed material/ui Related to Material/UI dependency react React knowledge needed ui/ux Issues related to design/UI/UX

Comments

@emibcn
Copy link
Owner

emibcn commented Oct 22, 2020

On small screens, there is no visual mark about an app update (unless the user manually opens the menu and sees the Update! link).

Proposal

On small devices (lower than md, when useMediaQuery(theme.breakpoints.down('md'));), add a MaterialUI Badge (with something like new on it) when there is an update available (props.newServiceWorkerDetected === true).

Where to add the Badge: https://github.com/emibcn/covid/blob/master/app/src/Dashboard.jsx#L168
@emibcn emibcn added enhancement New feature or request good first issue Good for newcomers Hacktoberfest Simple issues suitable Hacktoberfest PRs react React knowledge needed javascript Javascript knowledge needed ui/ux Issues related to design/UI/UX design Similar to UI/UX material/ui Related to Material/UI dependency labels Oct 22, 2020
carbarsoft added a commit to carbarsoft/covid that referenced this issue Oct 23, 2020
@carbarsoft
emibcn#35 update alert badge for small screens
406207f
carbarsoft added a commit to carbarsoft/covid that referenced this issue Oct 23, 2020
@carbarsoft
emibcn#35 update alert badge for small screens
a69fe43
@carbarsoft carbarsoft mentioned this issue Oct 23, 2020
Merged
@emibcn emibcn closed this as completed in d5a7bd1 Oct 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
design Similar to UI/UX enhancement New feature or request good first issue Good for newcomers Hacktoberfest Simple issues suitable Hacktoberfest PRs javascript Javascript knowledge needed material/ui Related to Material/UI dependency react React knowledge needed ui/ux Issues related to design/UI/UX
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@emibcn