Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: vendor depedendency mismatch #3

Closed
wants to merge 2 commits into from

Conversation

cyx
Copy link

@cyx cyx commented Mar 5, 2018

Rationale

Doing a go get yields an error, as follows:

$ go get -u github.com/emicklei/proto-contrib/cmd/protofmt
# github.com/emicklei/proto-contrib/cmd/protofmt
proto-contrib/cmd/protofmt/main.go:93:44: cannot use def (type *"github.com/emicklei/proto-contrib/cmd/protofmt/vendor/github.com/emicklei/proto".Proto) as type *"github.com/emicklei/proto".Proto in argument to protofmt.NewFormatter(output, "  ").Format

Changelog

  • Moves the vendor folder to the root of the project.

@amerine
Copy link

amerine commented Mar 5, 2018

@cyx Nice.

@emicklei
Copy link
Owner

emicklei commented Mar 5, 2018

what is happening here? My intension was for each command to have it own vendored packages. Apparently, that does not work (for you).

@cyx
Copy link
Author

cyx commented Mar 5, 2018

Are you able to make it work locally? I tried it also with go1.9 and same result. My understanding is that the vendor folder is causing issues.

@emicklei
Copy link
Owner

emicklei commented Mar 6, 2018

i reverted the change and will not proceed with vendoring. Instead, I will setup a Travis CI build job to verify the tools

@emicklei emicklei closed this Mar 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants