ignoring single-quoted reserved field names

[nilslice]

func TestReservedFieldNamesSingleQuote(t *testing.T) {
	r := new(Reserved)
	p := newParserOn(`reserved 'foo', 'bar';`)
	_, _, _ = p.next()
	err := r.parse(p)
	if err != nil {
		t.Fatal(err)
	}
	if got, want := len(r.FieldNames), 2; got != want {
		t.Fatalf("got [%v] want [%v]", got, want)
	}
	if got, want := r.FieldNames[0], "'foo'"; got != want {
		t.Errorf("got [%v] want [%v]", got, want)
	}
	if got, want := r.FieldNames[1], "'bar'"; got != want {
		t.Errorf("got [%v] want [%v]", got, want)
	}
}

I'm not certain about the expected "'bar'" or "'foo'" literals in the test, but the len(r.FieldNames) should be 2.

This is in reference to a user report from one of my repos: nilslice/protolock#65

[nilslice]

My PR (#95) seems to make the reserved w/ single-quote test pass, but when actually parsing a full message, I get this failure from the scanner pkg:

go scanner error at <input>:7:12 = illegal char literal        
go scanner error at <input>:7:21 = illegal char literal        
go scanner error at <input>:8:20 = illegal char literal

The message in question is:

syntax = "proto3";

package test;

message Channel {
  reserved 'thing', 'another';
  reserved "more", 'mixed';
  int64 id = 1;
  string name = 2;
  string description = 3;
}

[emicklei]

thank you for reporting this issue. I will investigate it and review the PR

[emicklei]

the parser is not (completely) validating the proto file so empty reserved names should not be ignored. Tools such as protolint and protoc will.
Please have a look at PR #96 which uses your fix to add a scanner mode and adds your message test.

[nilslice]

the parser is not (completely) validating the proto file so empty reserved names should not be ignored. Tools such as protolint and protoc will.

makes sense -- great callout.

Please have a look at PR #96 which uses your fix to add a scanner mode and adds your message test.

I will run through the test and build my tool against this version and try it out. Thanks!