Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New release? #21

Closed
hhartzer opened this issue Feb 27, 2022 · 7 comments
Closed

New release? #21

hhartzer opened this issue Feb 27, 2022 · 7 comments

Comments

@hhartzer
Copy link
Contributor

This is very cool. I'm looking to make a FreeBSD port for this. Looks like there's some useful new features since 1.13. Are you planning on releasing a new version that I can use in the port?

Thank you!

@hhartzer
Copy link
Contributor Author

Here is the port, if you are curious: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=262234

@emikulic
Copy link
Owner

That's a nice and concise Makefile. I'll do a release soon.

@hhartzer
Copy link
Contributor Author

Great, thank you!

@ffontaine
Copy link
Contributor

FYI, it seems that CVE-2020-25691 was assigned to darkhttpd. It would be great to fix this issue before making a new release (if it is not already fixed).

@hhartzer
Copy link
Contributor Author

I'm assuming this was fixed given the age of the CVE, but can't tell for sure. @emikulic would you be able to confirm?

@emikulic
Copy link
Owner

emikulic commented Oct 2, 2022

I can't find a patch or repro instructions for the CVE.

I tried to come up with a reproducer so I passed time=9223372036854775807 to strftime, and that crashes inside glibc:

#0  0x00007ffff7e65207 in __strftime_internal (s=0x7fffffffe060 "", maxsize=30, format=0x555555556018 "%a, %d %b %Y %H:%M:%S GMT", tp=0x0, 
    yr_spec=yr_spec@entry=0, tzset_called=tzset_called@entry=0x7fffffffdf67, loc=0x7ffff7f8c560 <_nl_global_locale>)
    at ./time/strftime_l.c:476
#1  0x00007ffff7e67398 in __GI___strftime_l (s=<optimized out>, maxsize=<optimized out>, format=<optimized out>, tp=<optimized out>, 
    loc=<optimized out>) at ./time/strftime_l.c:460
#2  0x0000555555555211 in rfc1123_date (dest=0x7fffffffe060 "", when=9223372036854775807) at darkhttpd.c:1458

@emikulic
Copy link
Owner

emikulic commented Oct 2, 2022

@emikulic emikulic closed this as completed Oct 2, 2022
arnout pushed a commit to buildroot/buildroot that referenced this issue Oct 6, 2022
- Drop patch (already in version)
- Fix CVE-2020-25691: emikulic/darkhttpd#21

https://github.com/emikulic/darkhttpd/releases/tag/v1.14

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
arnout pushed a commit to buildroot/buildroot that referenced this issue Oct 15, 2022
- Drop patch (already in version)
- Fix CVE-2020-25691: emikulic/darkhttpd#21

https://github.com/emikulic/darkhttpd/releases/tag/v1.14

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
(cherry picked from commit cced5b6)
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
arnout pushed a commit to buildroot/buildroot that referenced this issue Oct 15, 2022
- Drop patch (already in version)
- Fix CVE-2020-25691: emikulic/darkhttpd#21

https://github.com/emikulic/darkhttpd/releases/tag/v1.14

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
(cherry picked from commit cced5b6)
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants