[DragValue] Use rounded values for checking if value needs setting #2959
+4
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
old_value
is not rounded, the modified if-expression would always trigger clearing the edit memory, and hence making editing by keyboard impossible -- the edit buffer would only last a single frame.Alternatively,
old_value
could be always rounded if we rounded the result of parsing the keyboard input and accesskit input, but this prevents the user from inputting values more precise than allowed by default, which is a behavior I've personally found useful. Regardless of that, this solution is more likely to prevent this bug from being reintroduced if new input methods are added and don't respect rounding.