Add method to specify tip_size of plot arrows
#3138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilk
reviewed
Aug 9, 2023
Comment on lines
1024
to
1026
| /// Set the size of the arrow tips | ||
| pub fn tip_size(mut self, tip_size: f32) -> Self { | ||
| self.tip_size = Some(tip_size); |
There was a problem hiding this comment.
"size" is not very clear. Is it with width or the length of the tip? Calling it tip_length would make more sense imho
There was a problem hiding this comment.
Ok, I'm fine with "length". I already changed the name.
Normally the tip_size will be dependent on the arrow length. This patch adds a new method to explicitly set the arrow tip size.
nagua
force-pushed
the
add_plot_arrow_tip_size
branch
from
8bae777
to
cb061ae
Compare
emilk
approved these changes
Aug 9, 2023
emilk
changed the title
tip_size of plot arrows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello everyone,
For my application I want the plot arrows to always have the same size and currently the tip size
depends on the length of the arrow. So this patch adds a method to explicitly set the arrow tip size.
If this needs more discussion, I can additionally open an issue.
Have a nice day everyone!