Fix auto_bounds when only one axis has restricted navigation #3171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilk
approved these changes
Aug 9, 2023
|
Makes sense! Though your links are broken. You can just drag-drop mp4 videos into a GitHub PR description next time |
|
Thanks for merging.
Yeah, looks like those links expired. I'll keep that in mind for next time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue with plots where the auto-bounds feature for the y-axis would not work if navigation in the y-axis was restricted, but moving the x-axis was allowed. Any dragging or scrolling would lead to the auto-bounding being disabled, meaning the y-axis was not rescaled when new data came into view.
If that explanation makes no sense:
before: https://i.imgur.com/2bwRFNr.mp4
after: https://i.imgur.com/5TtD9fp.mp4
The solution is to only consider an axis to be modified if modifying that axis is actually allowed.