Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

egui: add redo support to Undoer #3478

Merged
merged 3 commits into from Nov 10, 2023
Merged

egui: add redo support to Undoer #3478

merged 3 commits into from Nov 10, 2023

Conversation

LoganDark
Copy link
Contributor

@LoganDark LoganDark commented Oct 17, 2023 •
edited by emilk

Better implementation than #3448. (by accident since I did not see that PR)

@LoganDark LoganDark changed the title Add redo support to Undoer egui: add redo support to Undoer Oct 17, 2023
@LoganDark
Copy link
Contributor Author

Honestly no idea why the labels check is failing. Either that or it means actual github labels which I don't have permission to apply.

@LoganDark
Copy link
Contributor Author

Hey @emilk what would it take to get this merged?

@emilk
Copy link
Owner

emilk commented Nov 10, 2023

Better implementation than #3448

Better how?

@LoganDark
Copy link
Contributor Author

Better implementation than #3448

Better how?

AFAIK this implementation just seemed more straightforward to me. I've since forgot the exact reason, though.

@LoganDark
Copy link
Contributor Author

Sigh. I literally ran cargo cranky. Not very cranky if it doesn't check formatting.

@LoganDark
Copy link
Contributor Author

In my own application, I have a variation of change history that allows you to have multiple redo stacks and switch between them, rather than them being cleared whenever you perform an action. However, that usually requires supporting UI, and isn't always intuitive to people, which is why I don't think it's right for egui to implement that itself. However, TextEdit makes it difficult to replace the default undo and redo actions with it. Not sure if there is an easy solution.

@emilk emilk added the egui label Nov 10, 2023
emilk
emilk approved these changes Nov 10, 2023
View reviewed changes
Copy link
Owner

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@emilk emilk merged commit 5201c04 into emilk:master Nov 10, 2023
19 of 20 checks passed
@LoganDark LoganDark deleted the redo branch November 10, 2023 20:36
@emilk emilk changed the title egui: add redo support to Undoer egui: add redo support to Undoer Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilk emilk emilk approved these changes

Assignees
No one assigned
Labels
egui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add redo to Undoer
2 participants
@LoganDark @emilk