Fix windowing problems when using the x11 feature on Linux
#3643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added by @konkitoman in #3172 I'm not sure what the hack is supposed to solve, but calling it every frame is a bad idea, as @ItsEthra reported in #3628 (comment) * Closes #3620 * Closes #3628
This was referenced Nov 27, 2023
|
Someone with a x11 compositor should check if multiple viewports still work as intended with this fix. Also comment mentions that newest winit will fix the behavior this hack is intended to fix, so maybe we can just wait for winit pr. |
|
That can be removed! But is a Plasma specific bug, that happens in multiples apps! |
|
Ok, then I'll remove the hack completely - thanks for the clarification @konkitoman ! |
emilk
changed the title
set_maximize each frame on Linuxx11 feature on Linux
emilk
added
eframe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was caused by a hack added by @konkitoman in #3172
The solution was reported by @ItsEthra in #3628 (comment)
Context::request_repaintis called #3620