TextEdit: fix crash when hitting SHIFT + TAB around non-ASCII text #3984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilk#3878 panic patch
Mingun
reviewed
Feb 11, 2024
Comment on lines
+92
to
+97
| let remove_len = if self.as_str().chars().nth(line_start.index) == Some('\t') { | ||
| Some(1) | ||
| } else if self.as_str()[line_start.index..] | ||
| } else if self | ||
| .as_str() | ||
| .chars() | ||
| .skip(line_start.index) |
There was a problem hiding this comment.
Iteration over chars two times can be time consuming for a long text. It is better to do that only once
There was a problem hiding this comment.
May be, you right.
However, it only works when we press SHIFT + TAB, so we don't need to change it.
|
PR Merge this for egui v0.26.3, Please. |
emilk
changed the title
emilk
approved these changes
Mar 12, 2024
emilk
added
bug
hacknus
pushed a commit
to hacknus/egui
that referenced
this pull request
Oct 30, 2024
…milk#3984) * Closes emilk#3846 * Closes emilk#3878 Dear emilk. Leaving aside other function, I think this is all you need to fix to patch the panic that occurs when Shift + TAB. Thank you, emilk.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
panicwhen pressing Shift + TAB in aTextEdit#3846Dear emilk.
Leaving aside other function,
I think this is all you need to fix to patch the panic that occurs when Shift + TAB.
Thank you, emilk.