egui: Fix incorrect handling of item spacing in Window title bar
#3995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
varphone
changed the title
varphone
force-pushed
the
feature/fix-window-title-bar
branch
from
9f8357e
to
c5f20d2
Compare
emilk
approved these changes
Feb 7, 2024
emilk
pushed a commit
that referenced
this pull request
Feb 10, 2024
Currently, the window title bar does not correctly handle the `item_spacing` and `window_margin`. * Video snapshot on changing the `item_spacing` and `window_margin` (master) [egui-demo-app-incorrect.webm](https://github.com/emilk/egui/assets/1274171/a4e32d43-69b5-44be-a4c3-97b0533147ca) * Video snapshot on changing the `item_spacing` and `window_margin` (feature/fix-window-title-bar) [egui-demo-app-fixed.webm](https://github.com/emilk/egui/assets/1274171/42bbc210-a1f3-4e0a-ab71-d068e58e0e35)
emilk
changed the title
Window title bar
hacknus
pushed a commit
to hacknus/egui
that referenced
this pull request
Oct 30, 2024
Currently, the window title bar does not correctly handle the `item_spacing` and `window_margin`. * Video snapshot on changing the `item_spacing` and `window_margin` (master) [egui-demo-app-incorrect.webm](https://github.com/emilk/egui/assets/1274171/a4e32d43-69b5-44be-a4c3-97b0533147ca) * Video snapshot on changing the `item_spacing` and `window_margin` (feature/fix-window-title-bar) [egui-demo-app-fixed.webm](https://github.com/emilk/egui/assets/1274171/42bbc210-a1f3-4e0a-ab71-d068e58e0e35)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the window title bar does not correctly handle the
item_spacingandwindow_margin.item_spacingandwindow_margin(master)egui-demo-app-incorrect.webm
item_spacingandwindow_margin(feature/fix-window-title-bar)egui-demo-app-fixed.webm