Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give each menu Area an id distinct from the id of what was clicked #4114

Merged
merged 3 commits into from
Feb 29, 2024

Conversation

emilk
Copy link
Owner

@emilk emilk commented Feb 29, 2024

Previously the Id of the menu Area was using the same id as the thing that was clicked (i.e. the button opening menu), which lead to id clashes

Previously the `Id` of the menu `Area` was using the same id as
the thing that was clicked (i.e. the button opening menu),
which lead to id clashes
@emilk emilk added bug Something is broken egui labels Feb 29, 2024
@emilk emilk merged commit 86d7f29 into master Feb 29, 2024
37 checks passed
@emilk emilk deleted the emilk/fix-menu-ids branch February 29, 2024 13:18
hacknus pushed a commit to hacknus/egui that referenced this pull request Oct 30, 2024
…milk#4114)

* Closes emilk#4113

Previously the `Id` of the menu `Area` was using the same id as the
thing that was clicked (i.e. the button opening menu), which lead to id
clashes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is broken egui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

debug assert when opening context menus
1 participant