Replace directories-next dependency with directories
#4661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`directories-next` was created because `directories` was not maintained at the time. However, it has gotten active maintainership since, and it has received more updates than `directories-next`. `directories` also has more recent downloads than its `next` counterpart, so it might make sense to switch to it, to avoid unnecessary duplicate dependencies, where a project depends transitively on both `directories` and `directories-next`.
crumblingstatue
commented
Jun 14, 2024
| @@ -52,7 +52,7 @@ skip = [ | |||
| { name = "libloading" }, # wgpu-hal itself depends on 0.8 while some of its dependencies, like ash and d3d12, depend on 0.7 | |||
| { name = "memoffset" }, # tiny dependency | |||
| { name = "quick-xml" }, # old version via wayland-scanner | |||
| { name = "redox_syscall" }, # old version via directories-next | |||
| { name = "redox_syscall" }, # old version via winit | |||
There was a problem hiding this comment.
I'm not exactly sure what is going on in this file, but with this change, winit is the crate referring to the oldest version of redox_syscall (0.3.5)
emilk
added
dependencies
hacknus
pushed a commit
to hacknus/egui
that referenced
this pull request
Oct 30, 2024
`directories-next` was created because `directories` was not maintained at the time. However, `directories` has gotten active maintainership since, and it has received more updates than `directories-next`. `directories` also has more recent downloads than its `next` counterpart, so it might make sense to switch to it, to avoid unnecessary duplicate dependencies, where a project depends transitively on both `directories` and `directories-next`. The main question is whether we depend on any specific behavior from `directories-next`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
directories-nextwas created becausedirectorieswas not maintained at the time. However,directorieshas gotten active maintainership since, and it has received more updates thandirectories-next.directoriesalso has more recent downloads than itsnextcounterpart, so it might make sense to switch to it, to avoid unnecessary duplicate dependencies, where a project depends transitively on bothdirectoriesanddirectories-next.The main question is whether we depend on any specific behavior from
directories-next.