Improved Behavior of Nested ScrollArea #4791
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We need a proper test for this, otherwise we will just go around in circles. The test could be a manual one (in https://github.com/emilk/egui/blob/master/tests/) for now. |
This is as simplified as possible. I tested it for a long time without any problems. Please review. |
|
completed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
When a
ScrollAreais nested with both Horizontal and Vertical scrolling, theouter_rectcan become very large due to the content, or when the content is moved. This can cause some issues.Improvement:
There's a part that handles this with a comment, which simplified and made to work better.
ScrollArearepeatedly appears and disappears quickly issue. #4658