Increase scroll speed for glium backend #702
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Each so called "line" of the MuseScrollDelta::LineDelta de-facto represents a single scroller click which in most cases equals to 15 degrees of wheel rotation. Currently, one scroller click scrolls exactly one line of the text, which is very slow. This change multiplies the scroll rate by 5. So, with one click of the scroller, 5 lines scrolled. This number is taken from the "iced" GUI library and feels quite balanced. Fixes emilk#461
|
Thank you! I did my own commit because I felt we should change egui_web at the same time, and update the changelog |
|
egui_web was totally fine. With 50 as multiplier it scrolls for 300 pixels per click. |
emilk
added a commit
that referenced
this pull request
Sep 7, 2021
|
Haha 🤦 - thanks for testing @akhilman ! The change has been reverted |
mankinskin
pushed a commit
to mankinskin/egui
that referenced
this pull request
Sep 29, 2021
mankinskin
pushed a commit
to mankinskin/egui
that referenced
this pull request
Sep 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each so called "line" of the MuseScrollDelta::LineDelta de-facto represents
a single scroller click which in most cases equals to 15 degrees of wheel
rotation.
Currently, one scroller click scrolls exactly one line of the text,
which is very slow.
This change multiplies the scroll rate by 5. So, with one click of the
scroller, 5 lines scrolled. This number is taken from the "iced" GUI
library and feels quite balanced.
Closes #461