Fix a compilation warning - directive output may be truncated #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a simple solution to a compilation warning that doesn't require any special changes to be made to already existing enums, types or logic.
loguru/loguru.cpp: In function ‘void loguru::print_preamble(char*, size_t, loguru::Verbosity, const char*, unsigned int)’:
loguru/loguru.cpp:1208:50: warning: ‘% 4d’ directive output may be truncated writing between 4 and 11 bytes into a region of size 5 [-Wformat-truncation=]
1208 | snprintf(level_buff, sizeof(level_buff) - 1, "% 4d", verbosity);
| ^~~~
loguru/loguru.cpp:1208:49: note: directive argument in the range [1, 2147483647]
1208 | snprintf(level_buff, sizeof(level_buff) - 1, "% 4d", verbosity);
| ^~~~~~
In file included from /usr/include/stdio.h:867,
from /usr/include/c++/9/cstdio:42,
from /usr/include/c++/9/ext/string_conversions.h:43,
from /usr/include/c++/9/bits/basic_string.h:6493,
from /usr/include/c++/9/string:55,
from /usr/include/c++/9/stdexcept:39,
from /usr/include/c++/9/array:39,
from /usr/include/c++/9/tuple:39,
from /usr/include/c++/9/functional:54,
from /usr/include/c++/9/pstl/glue_algorithm_defs.h:13,
from /usr/include/c++/9/algorithm:71,
from loguru/loguru.cpp:36:
/usr/include/x86_64-linux-gnu/bits/stdio2.h:67:35: note: ‘__builtin___snprintf_chk’ output between 5 and 12 bytes into a destination of size 5
67 | return __builtin___snprintf_chk (__s, __n, __USE_FORTIFY_LEVEL - 1,
| ~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
68 | __bos (__s), __fmt, __va_arg_pack ());
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
|
Can you please format the description by using |
bylowerik
reviewed
Feb 21, 2022
loguru.cpp
Outdated
| @@ -1311,7 +1311,7 @@ namespace loguru | |||
| if (custom_level_name) { | |||
| snprintf(level_buff, sizeof(level_buff) - 1, "%s", custom_level_name); | |||
| } else { | |||
| snprintf(level_buff, sizeof(level_buff) - 1, "% 4d", verbosity); | |||
| snprintf(level_buff, sizeof(level_buff) - 1, "% 4d", (int8_t)verbosity); | |||
There was a problem hiding this comment.
Maybe we could be more explicit and do static_cast<int8_t>(verbosity)?
There was a problem hiding this comment.
Yeah, sure, why not. Just keep in mind that all of this was a slightly hackish solution to begin with.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a simple solution to a compilation warning that doesn't require any special changes to be made to already existing enums, types or logic.