Various fixes for FreeBSD and OpenBSD #245
Open
+14
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the final else, buff is not used, so duplicated into the branches where it is actually used.
This was referenced Oct 11, 2023
Open
|
I have verified that this builds in OpenBSD, FreeBSD, and macOS, but not other platforms. @mathstuf care to review? This would be nice to get into VTK too as it fixes compiler errors. |
mathstuf
reviewed
Oct 11, 2023
This fixes a compiler error on that platform, because of the nearby assumption that pthread_t is an integer type, when it is in fact a pointer on OpenBSD (and macOS).
Also added explict cast for dubious non-portable conversion of pthread_t to integer.
strerror_r has been available since FreeBSD 4.4 and OpenBSD 3.3 (both many years ago).
…`pthread_getname_np` Annoyingly, these functions are spelt differently on different OSes.
mathstuf
approved these changes
Oct 12, 2023
kwrobot
pushed a commit
to Kitware/VTK
that referenced
this pull request
Oct 19, 2023
Includes emilk/loguru#245 and commits needed to allow them to apply cleanly.
kwrobot
pushed a commit
to Kitware/VTK
that referenced
this pull request
Oct 19, 2023
Includes emilk/loguru#245 and commits needed to allow them to apply cleanly.
|
@emilk would you be able to review this please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.