Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add threshold to start swipe #72

Merged
merged 6 commits into from
May 24, 2023

Conversation

joaom00
Copy link
Contributor

@joaom00 joaom00 commented May 16, 2023

No description provided.

@vercel
Copy link

vercel bot commented May 16, 2023

Someone is attempting to deploy a commit to a Personal Account owned by @emilkowalski on Vercel.

@emilkowalski first needs to authorize it.

@emilkowalski
Copy link
Owner

Could you help me understand what this PR is doing?

@joaom00
Copy link
Contributor Author

joaom00 commented May 17, 2023

Basically the user needs to move a certain amount of pixels (2px with mouse and 10px with touch) on the y-axis to start swiping the toast. To avoid this:

Before

before.mp4

After

after.mp4

@vercel
Copy link

vercel bot commented May 23, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sonner ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 24, 2023 6:18pm

@emilkowalski
Copy link
Owner

emilkowalski commented May 23, 2023

@joaom00 Seems like some tests are failing. Could you take a look at those?

emilkowalski and others added 4 commits May 24, 2023 13:30
* Write initial update logic

* Progress

* Calculate height correctly

* Update

* Update readme

* Revert hero changes

* Fix logic

* Center toasts on smaller screens

* Update
@joaom00
Copy link
Contributor Author

joaom00 commented May 24, 2023

@emilkowalski Fixed

@emilkowalski emilkowalski merged commit 5cb703e into emilkowalski:main May 24, 2023
@joaom00 joaom00 deleted the start-move-buffer branch May 24, 2023 19:45
@joaom00 joaom00 mentioned this pull request Jul 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants