Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial support of 64bit userspace on ARM #533

Merged
merged 1 commit into from
Apr 10, 2023
Merged

Initial support of 64bit userspace on ARM #533

merged 1 commit into from
Apr 10, 2023

Conversation

horstle
Copy link
Collaborator

@horstle horstle commented Mar 24, 2023 •
edited
Loading

Closes #530

So far only LAZOR (and some others which use the same image) has the 64bit library. We need to monitor the other images for when/if they make the switch.
The path for find_file() could be changed accordingly, since the lib is not in arm_cros, but arm_cros64 in those images.

@horstle
Copy link
Collaborator Author

horstle commented Mar 24, 2023

We should add a check for the bitness of the lib, if the CHROMEOS_RECOVERY_ARM_HWIDS list becomes out of date, users might install the 64bit lib on 32bit.

@horstle horstle marked this pull request as draft March 24, 2023 14:15
@eqikkwkp25-cyber eqikkwkp25-cyber mentioned this pull request Mar 25, 2023
Closed
@horstle horstle force-pushed the arm64 branch 3 times, most recently from b4a50a8 to 021c3e0 Compare March 26, 2023 15:00
@sonarcloud
Copy link

sonarcloud bot commented Mar 26, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@horstle
Copy link
Collaborator Author

horstle commented Mar 26, 2023

If anybody want's to test this, please install
script.module.inputstreamhelper-0.5.10+matrix.1-arm64-3983f12.zip

@horstle horstle marked this pull request as ready for review March 26, 2023 15:27
@horstle horstle mentioned this pull request Mar 26, 2023
Closed
@horstle
Copy link
Collaborator Author

horstle commented Apr 10, 2023

I tested it as much as I could, and it seems fine. Going to merge it now.

@horstle horstle merged commit 86f5ab4 into emilsvennesson:master Apr 10, 2023
@horstle horstle deleted the arm64 branch April 10, 2023 11:45
@Deadmansshoe Deadmansshoe mentioned this pull request Apr 30, 2023
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mediaminister mediaminister Awaiting requested review from mediaminister

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Widevine AARCH64 now available
1 participant
@horstle