Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create option to choose Widevine version to install from repo. #538

Merged
merged 1 commit into from
Apr 30, 2023
Merged

Create option to choose Widevine version to install from repo. #538

merged 1 commit into from
Apr 30, 2023

Conversation

horstle
Copy link
Collaborator

@horstle horstle commented Apr 25, 2023 •
edited
Loading

@horstle horstle mentioned this pull request Apr 25, 2023
Closed
@horstle horstle force-pushed the install_choosable branch 2 times, most recently from 851fb33 to a9961b3 Compare April 25, 2023 14:41
@horstle horstle mentioned this pull request Apr 27, 2023
Closed
@CastagnaIT
Copy link

CastagnaIT commented Apr 28, 2023 •
edited
Loading

tested on a clean Kodi 21 but when i choosed re-install CDM addon is crashed
https://paste.kodi.tv/awemenexiy.kodi

@horstle horstle force-pushed the install_choosable branch 2 times, most recently from 58685cb to 75a5062 Compare April 29, 2023 19:36
@horstle
Copy link
Collaborator Author

horstle commented Apr 29, 2023 •
edited
Loading

Your system apparently doesn't have setuptools, so the addon uses a deprecated method as fallback, but the variable returned by that is not hashable. Should be fixed now. I also updated the zips in the original comment.

@CastagnaIT
Copy link

Your system apparently doesn't have setuptools

on Windows kodi have python embedded dont use system installed python

tested new link above but now raise another error:
https://paste.kodi.tv/gokojoyetu.kodi

@sonarcloud
Copy link

sonarcloud bot commented Apr 30, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@horstle
Copy link
Collaborator Author

horstle commented Apr 30, 2023

Right, stupid mistake...

Fixed and new zips in the start post.

@CastagnaIT
Copy link

yes now works thanks
just a little improvement, after you installed an older CDM version it immediately ask to update to last version
if you have just installed an old version, there is no point in asking me to update to the latest version immediately
imo this operation that should be automatically skipped and delayed on the specified days

@horstle
Copy link
Collaborator Author

horstle commented Apr 30, 2023

Actually it does that. After the install finished, you probably didn't us "OK" to exit the settings. The addon stores the install time in a hidden setting, but that doesn't actually get saved, if you don't press "OK". It's basically the same issue as #421.

@horstle horstle merged commit ae4972f into emilsvennesson:master Apr 30, 2023
@horstle horstle deleted the install_choosable branch April 30, 2023 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature requests for more expert control
2 participants
@horstle @CastagnaIT