Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plans #1

Open
emilyamorris opened this issue Mar 19, 2018 · 6 comments
Open

Plans #1

emilyamorris opened this issue Mar 19, 2018 · 6 comments

Comments

@emilyamorris
Copy link
Owner

Seems good so far @slednicky and @JuliaClaireLee

thank you for doing so many things over break @JuliaClaireLee !!!

We should change the function so the plot is a bit prettier, maybe make the information on it slightly clearer, but otherwise it's a really cool kind of information to show. There are definitely easy style things to change. Then we can apply it to the whole list of states and make sure we can see all the resulting 50 plots at once.

I'm going to work on making the function put out a prettier looking plot unless @JuliaClaireLee wants to. One of us needs to work on code folding and organizing, and one of us needs to write descriptions. I'm happy to do any of it.

@slednicky
Copy link
Collaborator

thanks @emilyamorris for organizing this thread

I'm happy to start working on code folding / organizing / descriptions / anything else that comes up !

@slednicky
Copy link
Collaborator

a couple questions: is anyone else having trouble knitting since the file is so large? also, @emilyamorris is the bit at the end the idea you had about possibly mapping incumbents vs challengers? trying to figure out where we can go next/ how I can be the most help

@emilyamorris
Copy link
Owner Author

emilyamorris commented Mar 20, 2018 via email

@slednicky
Copy link
Collaborator

yes, @emilyamorris I will do that later today!

@slednicky slednicky reopened this Mar 20, 2018
@emilyamorris
Copy link
Owner Author

emilyamorris commented Mar 20, 2018 via email

@slednicky
Copy link
Collaborator

I did some revising, feel free to edit though, especially the comparison between republican and democratic. I think there's prob some more intelligent things to say, I'm just not thinking of them atm. I will also come back to it later and take another look. Also, I'm not sure what to say under the "setting up the plot function" heading. thanks all !!

emilyamorris added a commit that referenced this issue Mar 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants