Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use c_char, which is the proper alias to use with CStr #30

Merged
merged 1 commit into from
Apr 1, 2019
Merged

Use c_char, which is the proper alias to use with CStr #30

merged 1 commit into from
Apr 1, 2019

Conversation

ErichDonGubler
Copy link
Contributor

@ErichDonGubler ErichDonGubler commented Mar 28, 2019

See std docs here.

Just using i8 breaks things like aarch64, which actually have a different definition of char in C. :) And yes, that means I'm actually participating in a project where this is getting ported to embedded devices!

@ErichDonGubler
Copy link
Contributor Author

EDIT: Updated OP with some more info. And hopefully something cool for you as a maintainer! :)

@eminence
Copy link
Owner

eminence commented Apr 1, 2019

Thanks! BTW, are you running on a real aarch64 machine? or some emulated that? I'm asking because I'd be interested in learning how to test on other platforms than amd64 (and testing with travis CI, if at all possible).

@eminence eminence merged commit 4e3b067 into eminence:master Apr 1, 2019
@ErichDonGubler ErichDonGubler deleted the cross-compile-fixes branch April 1, 2019 17:16
@ErichDonGubler
Copy link
Contributor Author

We're on a real one! I'd definitely suggest you take a look at trust for testing on different architectures and platforms. It's a Docker-heavy flow, but it's a great solution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants