Verify email process #60
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eminx
requested changes
Jul 7, 2022
| const accountVerification = Accounts.sendVerificationEmail(userId); | ||
| Meteor.call('sendVerificationLink', accountVerification); | ||
| // console.log(accountVerification); | ||
|
|
||
| Meteor.call('sendWelcomeEmail', userId); |
There was a problem hiding this comment.
We should only send the welcome email once user clicks and activates the account...
| const newUrl = url.replace('#/', ''); | ||
| return `Hi, To verify your account email, simply click the link below. ${newUrl}`; | ||
| }, | ||
| }; | ||
| }); |
There was a problem hiding this comment.
I think we need to somehow handle the i18n in this, since we have swedish users who would want in swedish...
| emails: | ||
| verifyEmail: | ||
| subject: Please verify your email address | ||
| body: Hi, To verify your account email, simply click the link below |
| @@ -16,6 +16,10 @@ Meteor.methods({ | |||
| try { | |||
| const userId = Accounts.createUser(values); | |||
| if (userId) { | |||
| const accountVerification = Accounts.sendVerificationEmail(userId); | |||
There was a problem hiding this comment.
This is causing the email to be sent already once. And then in the following method sendVerificationLink, there's another email coming. So there are two emails that arrive...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sending a custom verification mail on new sign up.
Verify mail on a custom route/page and checks if it's already verified.