Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion for Navio2 C++ library #9

Closed
chutsu opened this issue May 9, 2016 · 2 comments
Closed

Suggestion for Navio2 C++ library #9

chutsu opened this issue May 9, 2016 · 2 comments

Comments

@chutsu
Copy link

chutsu commented May 9, 2016

I've been toying around with the C++ library, and wasn't satisfied with the way the code is layed out in the repo. As a programmer I was expecting a Makefile for the Navio C++ portion that builds the library and installs it to the right place so I can link it. I instead made my own, check it out here.

It essentially builds the library and examples. I would happily transfer this work to you guys if you like.

@staroselskii
Copy link
Contributor

@chutsu

It'd be very nice to see a PR! We can discuss it in details there, alright?

@chutsu
Copy link
Author

chutsu commented May 9, 2016

Well the repo I made only contains your C++ library code, not the python and scripts. So I'm not sure a PR here makes sense. Plus I didn't fork from the github repo so PR is not possible I don't think.

@chutsu chutsu closed this as completed Feb 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants